nice -n huge_num true #10213

oech3 · 2026-01-13T10:48:20Z

github-actions · 2026-01-13T11:29:03Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

github-actions · 2026-01-13T15:54:35Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

sylvestre · 2026-01-13T21:53:21Z

tests/by-util/test_nice.rs

+fn test_nice_huge() {
+    new_ucmd!()
+        .args(&[
+            "-n",


Only positive overflow is tested. Should add a test for negative overflow (e.g., -999...9) to ensure both clamping directions work.

Negative is root test, would not work on the CI.
...
Oh yes. It should work with permission denied.

github-actions · 2026-01-14T00:59:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

sylvestre · 2026-01-17T16:19:07Z

src/uu/nice/src/nice.rs

-                        translate!("nice-error-invalid-number", "value" => nstr.clone(), "error" => e),
-                    ));
+                    // clamp huge values
+                    let trimmed = nstr.trim();


i think moving it into a function could help with readability

Is this operation duplicated at somethere?

tests/by-util/test_nice.rs

codspeed-hq · 2026-01-17T16:49:40Z

Merging this PR will not alter performance

✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks¹

_{Comparing oech3:nice-huge (f510a9c) with main (037b958)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-17T18:00:34Z

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-17T20:59:30Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

tests/by-util/test_nice.rs

github-actions · 2026-01-17T21:45:41Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

github-actions · 2026-01-17T22:03:19Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

src/uu/nice/src/nice.rs

tests/by-util/test_nice.rs

github-actions · 2026-01-18T04:52:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

github-actions · 2026-01-18T11:12:23Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

github-actions · 2026-01-18T12:35:50Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

oech3 changed the title ~~Nice huge~~ nice -n huge_num true Jan 13, 2026

oech3 force-pushed the nice-huge branch 2 times, most recently from eec8ae2 to ae0c818 Compare January 13, 2026 10:50

oech3 mentioned this pull request Jan 13, 2026

tests: nice -n 9999999999999999999999999999999999999999999999999999999999999… coreutils/coreutils#170

Closed

sylvestre reviewed Jan 13, 2026

View reviewed changes

src/uu/nice/src/nice.rs Outdated Show resolved Hide resolved

oech3 force-pushed the nice-huge branch 2 times, most recently from 4ce1311 to 7a75ddd Compare January 13, 2026 15:42

oech3 force-pushed the nice-huge branch from 7a75ddd to d7f458d Compare January 13, 2026 16:11

sylvestre reviewed Jan 13, 2026

View reviewed changes

oech3 force-pushed the nice-huge branch 2 times, most recently from fae9d13 to 0166306 Compare January 14, 2026 00:47